(2015/02/18 23:21), Miroslav Benes wrote:
> Storage-class specifier 'extern' is redundant in front of the function
> declaration. According to the C specification it has the same meaning as
> if not present at all. So remove it.
>
> Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
Looks good to me.
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> ---
> arch/x86/include/asm/livepatch.h | 4 ++--
> include/linux/livepatch.h | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h
> index a455a53..2d29197 100644
> --- a/arch/x86/include/asm/livepatch.h
> +++ b/arch/x86/include/asm/livepatch.h
> @@ -32,8 +32,8 @@ static inline int klp_check_compiler_support(void)
> #endif
> return 0;
> }
> -extern int klp_write_module_reloc(struct module *mod, unsigned long type,
> - unsigned long loc, unsigned long value);
> +int klp_write_module_reloc(struct module *mod, unsigned long type,
> + unsigned long loc, unsigned long value);
>
> static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> {
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index 95023fd..ee6dbb3 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -123,10 +123,10 @@ struct klp_patch {
> enum klp_state state;
> };
>
> -extern int klp_register_patch(struct klp_patch *);
> -extern int klp_unregister_patch(struct klp_patch *);
> -extern int klp_enable_patch(struct klp_patch *);
> -extern int klp_disable_patch(struct klp_patch *);
> +int klp_register_patch(struct klp_patch *);
> +int klp_unregister_patch(struct klp_patch *);
> +int klp_enable_patch(struct klp_patch *);
> +int klp_disable_patch(struct klp_patch *);
>
> #endif /* CONFIG_LIVEPATCH */
>
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
