On Thu, Dec 11, 2014 at 12:17:33PM +0100, Petr Mladek wrote: > On Wed 2014-12-10 09:25:06, Josh Poimboeuf wrote: > > On Wed, Dec 10, 2014 at 11:11:47AM +0100, Petr Mladek wrote: > > > On Tue 2014-12-09 12:32:49, Josh Poimboeuf wrote: > > But livepatch isn't a module, it's part of the kernel. > > Ah, I remembered that module_init(klp_init) and created a wrong mental link ;-) > > > Even if the init > > function returns an error, that doesn't prevent any of the other > > exported functions from getting called. > > Well, it still will be covered by that later klp_patch_is_registered() > check. But I am find with leaving it as is. True, it's probably only necessary to call klp_is_enabled() from the register function. And I'm thinking it should probably have a better name, like klp_initialized(). But that's a minor cosmetic change, so if there are no more comments for the v6 patch set, I can send a separate patch for that later. -- Josh -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
