Hi, thank you for the revision. I'll rebase our patches on top of that. Anyway there is a small bug in a header file. See below. On Sun, 16 Nov 2014, Seth Jennings wrote: [...] > diff --git a/arch/x86/include/asm/livepatch.h b/arch/x86/include/asm/livepatch.h > new file mode 100644 > index 0000000..c5fab45 > --- /dev/null > +++ b/arch/x86/include/asm/livepatch.h > @@ -0,0 +1,38 @@ > +/* > + * livepatch.h - x86-specific Live Kernel Patching Core > + * > + * Copyright (C) 2014 Seth Jennings <sjenning@xxxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, see <http://www.gnu.org/licenses/>. > + */ > + > +#ifndef _ASM_X86_LIVEPATCH_H > +#define _ASM_X86_LIVEPATCH_H > + > +#include <linux/module.h> > + > +#ifdef CONFIG_LIVE_PATCHING > +extern int lpc_write_module_reloc(struct module *mod, unsigned long type, > + unsigned long loc, unsigned long value); > + > +#else > +static int lpc_write_module_reloc(struct module *mod, unsigned long type, > + unsigned long loc, unsigned long value); > +{ > + pr_err("Kernel does not support live patching\n"); > + return -ENOSYS; > +} > +#endif > + > +#endif /* _ASM_X86_LIVEPATCH_H */ There should not be a semicolon at the end of the function header in #else branch. Regards, --- Miroslav Benes SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
