On Thu, Mar 06, 2025 at 10:28:30AM +1100, Dave Chinner wrote: > Yes, but that misses my point: this is a folio conversion, whilst > this treats a folio as a page. The code covers both folios and slab. willy has explicitly NAKed using folio helpers for slab. So if we'd really want to use folio helpers here we'd need to special case them vs slab. That's why I keep using the existing API for now until the block layer grows better helpers, on which I'm waiting. And this is not new code, it's relatively minor refactoring of the existing code.