Re: [PATCH 11/12] xfs: cleanup mapping tmpfs folios into the buffer cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 11/12] xfs: cleanup mapping tmpfs folios into the buffer cache
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 4 Mar 2025 15:11:40 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Carlos Maiolino <cem@xxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20250226173931.GS6242@frogsfrogsfrogs>
References: <20250226155245.513494-1-hch@lst.de> <20250226155245.513494-12-hch@lst.de> <20250226173931.GS6242@frogsfrogsfrogs>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Feb 26, 2025 at 09:39:31AM -0800, Darrick J. Wong wrote:
> > +int xmbuf_map_backing_mem(struct xfs_buf *bp);
> 
> Does this actually work if CONFIG_XFS_MEMORY_BUFS=n ?  I guess the
> compiler will see:
> 
> 	if (false)
> 		return xmbuf_map_backing_mem(bp);
> 
> and optimize it out, right?

Exactly.

References:
- use folios and vmalloc for buffer cache backing memory
  - From: Christoph Hellwig
- [PATCH 11/12] xfs: cleanup mapping tmpfs folios into the buffer cache
  - From: Christoph Hellwig
- Re: [PATCH 11/12] xfs: cleanup mapping tmpfs folios into the buffer cache
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 06/12] xfs: remove the kmalloc to page allocator fallback
Next by Date: Re: [PATCH 10/12] xfs: use vmalloc instead of vm_map_area for buffer backing memory
Previous by thread: Re: [PATCH 11/12] xfs: cleanup mapping tmpfs folios into the buffer cache
Next by thread: [PATCH 01/12] xfs: unmapped buffer item size straddling mismatch
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux