On Wed, Feb 26, 2025 at 09:33:33AM -0800, Darrick J. Wong wrote: > > - mm_account_reclaimed_pages(bp->b_page_count); > > + mm_account_reclaimed_pages( > > + DIV_ROUND_UP(BBTOB(bp->b_length), PAGE_SIZE)); > > Why do we round the number of bytes in the buffer up to base page size? > > Don't we want howmany(BBTOB(bp->b_length), PAGE_SIZE) here? > > Oh wait, howmany *is* DIV_ROUND_UP. Never mind... I'll use howmany for consistency with the rest of the XFS code. > > - /* Make sure that we have a page list */ > > + /* Assure zeroed buffer for non-read cases. */ > > + if (!(flags & XBF_READ)) > > + gfp_mask |= __GFP_ZERO; > > Didn't this get added ten lines up in "xfs: remove the kmalloc to page > allocator fallback"? Yes. Looks like I didn't finish my refatoring to not duplicate this properly.
