On Tue, Feb 25, 2025 at 10:01:32AM +0000, John Garry wrote: > On 24/02/2025 20:26, Darrick J. Wong wrote: > > > + if (error) > > > + return error; > > > + xfs_ilock(ip, XFS_ILOCK_EXCL); > > > + xfs_trans_ijoin(tp, ip, 0); > > > + > > > + error = xfs_reflink_end_cow_extent_locked(tp, ip, offset_fsb, end_fsb); > > Overly long line, but otherwise looks fine. > > The limit is 80, right? That line fills out to 80. Ah, right, forgot that I have vim set up to display the right margin at 72 for emails. --D > > With that fixed, > > Reviewed-by: "Darrick J. Wong"<djwong@xxxxxxxxxx> > > > > cheers > >
