Re: [XFSPROGS PATCH] make: remove the .extradep file in libxfs on "make clean"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 19, 2025 at 11:05:00AM -0500, Theodore Ts'o wrote:
> Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++
> compiler") will create the .extradep file.  This can cause future
> builds to fail if the header files in $(DESTDIR) no longer exist.
> 
> Fix this by removing .extradep (along with files like .ltdep) on a
> "make clean".
> 
> Fixes: 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler")
> Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>

Looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>


> ---
>  include/buildrules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/buildrules b/include/buildrules
> index 7a139ff0..6b76abce 100644
> --- a/include/buildrules
> +++ b/include/buildrules
> @@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1
>  include $(TOPDIR)/include/builddefs
> 
>  clean clobber : $(addsuffix -clean,$(SUBDIRS))
> -	@rm -f $(DIRT) .ltdep .dep
> +	@rm -f $(DIRT) .ltdep .dep .extradep
>  	@rm -fr $(DIRDIRT)
>  %-clean:
>  	@echo "Cleaning $*"
> --
> 2.47.2
> 
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux