On Tue, Feb 18, 2025 at 12:10:29PM -0800, Darrick J. Wong wrote: > On Mon, Feb 17, 2025 at 10:31:27AM +0100, Christoph Hellwig wrote: > > xfs_buf_readahead_map is the only caller of xfs_buf_read_map and thus > > _xfs_buf_read that is not synchronous. Split it from xfs_buf_read_map > > so that the asynchronous path is self-contained and the now purely > > synchronous xfs_buf_read_map / _xfs_buf_read implementation can be > > simplified. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Thanks for adding the ASSERT as a guardrail against misuse of > xfs_buf_read. I was just going to remove the argument, but that would clash with the refactoring in the zoned series. But I plan to send that later.