On Fri, Feb 14, 2025 at 09:56:44AM -0800, Darrick J. Wong wrote: > > The tools/ directory never be installed into /var/lib/xfstests. If someone runs > > xfstests after `make install`, all tests will be failed due to: > > > > Failed to find executable ./tools/run_setsid: No such file or directory > > Urrrk, yeah, I didn't realize that tools/ doesn't have a Makefile, > therefore nothing from there get installed. Three options: > > 1) Add a tools/Makefile and an install target > 2) Update the top level Makefile's install target to install the two > scripts > 3) Move tools/run_* to the top level and (2) Looking at tools, it seems like there are a couple of different categories of scripts in the directory. Some are useful to people who are developing fstests (mkgroupfile, nextid, mvtest); some are useful when debugging a test failure (dm-logwrite-replay); some are useful only to xfs developers (ag-wipe, db-walk). And to this we are adding utility programs that would be used during a test execution. I wonder if we should split out these scripts into different directories? - Ted
