On Wed, Feb 12, 2025 at 12:39:56PM +0000, Nirjhar Roy (IBM) wrote: > This test is to verify that repeated warnings are not printed > for default options (attr2, noikeep) and warnings are > printed for non default options (noattr2, ikeep). Remount > with noattr2 fails on a v5 filesystem, so skip the mount option. Why do we care if remount succeeds or fails? That's not what the test is exercising. i.e. We are testing to see if the appropriate deprecation warning for a deprecated mount option has been issued or not, and that should happen regardless of whether the mount option is valid or not for the given filesysetm format.... Hence I don't see any reason for changing the test to exclude noattr2 testing on v5 filesystems... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx