On Thu, Feb 06, 2025 at 02:54:25PM -0800, Darrick J. Wong wrote: > -extern void rmap_avoid_check(void); > +extern void rmap_avoid_check(struct xfs_mount *mp); You might want to drop the extern while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>