On Thu, Feb 06, 2025 at 02:31:41PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Clean up all the open-coded logic to construct a file handle from a > fshandle and some bulkstat/parent pointer information. The new > functions are stashed in a private header file to avoid leaking the > details of xfs_handle construction in the public libhandle headers. So creating a handle from bulkstat is a totally normal thing to do for xfs-aware applications. I'd much rathe see this in libhandle than hiding it away. > + handle_from_fshandle(&handle, file->fshandle, file->fshandle_len); Nit: overly long line.
