On 2/3/25 2:55 AM, Lukas Herbolt wrote:
> If there is corrutpion on the filesystem andxfs_repair
> fails to repair it. The last resort of getting the data
> is to use norecovery,ro mount. But if the NEEDSREPAIR is
> set the filesystem cannot be mounted. The flag must be
> cleared out manually using xfs_db, to get access to what
> left over of the corrupted fs.
>
> Signed-off-by: Lukas Herbolt <lukas@xxxxxxxxxxx>
> ---
> fs/xfs/xfs_super.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 394fdf3bb535..c2566dcc4f88 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1635,8 +1635,12 @@ xfs_fs_fill_super(
> #endif
> }
>
> - /* Filesystem claims it needs repair, so refuse the mount. */
> - if (xfs_has_needsrepair(mp)) {
> + /*
> + * Filesystem claims it needs repair, so refuse the mount unless
> + * norecovery is also specified, in which case the filesystem can
> + * be mounted with no risk of further damage.
> + */
> + if (xfs_has_needsrepair(mp) && !xfs_has_norecovery(mp)) {
> xfs_warn(mp, "Filesystem needs repair. Please run xfs_repair.");
> error = -EFSCORRUPTED;
> goto out_free_sb;
thanks Lukas, this looks good to me as well. And with ro,norecovery
there should (tm) be no writes whatever to the filesystem so risk of
introducing further corruption from the mount should be zero.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
