On Tue, Feb 04, 2025 at 08:30:40AM -0500, Brian Foster wrote: > As a final step for generic iter advance, export the helper and > update it to return the remaining length of the current iteration > after the advance. This will usually be 0 in the iomap_iter() case, > but will be useful for the various operations that iterate on their > own and will be updated to advance as they progress. Normally we use export for adding EXPORT_SYMBOL*, so the subject confused me a bit. The patch itself looks good, though: Reviewed-by: Christoph Hellwig <hch@xxxxxx>