On Wed, Jan 22, 2025 at 11:34:37AM -0800, Darrick J. Wong wrote: > The particular place that I noticed this was on my fstests fleet, where > the root filesystem is an ro nfs4 export. I forgot to configure an > overlayfs for /var/lib/xfsprogs, so when I upgraded it to xfsprogs 6.12 > and left the VMs running on a Sunday morning, they tried to start > xfs_scrub_all and failed. Then the monitoring systems emailed me about > that, and I got 150 emails. :( > > This /should/ be a pretty uncommon situation since (AFAICT) most > readonly-root systems set up a writable (and possibly volatile) > /var/lib, but I thought I should just turn off the timer if it's going > to fail anyway. Can you write this up in a comment in the systemd unit file? With that the patch looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
