Re: [PATCH 2/4] release.sh: add --kup to upload release tarball to kernel.org

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-01-16 14:22:27, Darrick J. Wong wrote:
> On Fri, Jan 10, 2025 at 12:05:07PM +0100, Andrey Albershteyn wrote:
> > Signed-off-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>
> > ---
> >  release.sh | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> > 
> > diff --git a/release.sh b/release.sh
> > index b15ed610082f34928827ab0547db944cf559cef4..a23adc47efa5163b4e0082050c266481e4051bfb 100755
> > --- a/release.sh
> > +++ b/release.sh
> > @@ -16,6 +16,30 @@ set -e
> >  version=${PKG_MAJOR}.${PKG_MINOR}.${PKG_REVISION}
> >  date=`date +"%-d %B %Y"`
> >  
> > +KUP=0
> > +
> > +help() {
> > +	echo "$(basename) - create xfsprogs release"
> > +	printf "\t[--kup|-k] upload final tarball with KUP\n"
> > +}
> > +
> > +while [ $# -gt 0 ]; do
> > +	case "$1" in
> > +		--kup|-k)
> > +			KUP=1
> > +			;;
> > +		--help|-h)
> > +			help
> > +			exit 0
> > +			;;
> > +		*)
> > +			>&2 printf "Error: Invalid argument\n"
> > +			exit 1
> > +			;;
> > +		esac
> > +	shift
> > +done
> > +
> >  echo "Cleaning up"
> >  make realclean
> >  rm -rf "xfsprogs-${version}.tar" \
> > @@ -52,4 +76,11 @@ gpg \
> >  
> >  mv "xfsprogs-${version}.tar.asc" "xfsprogs-${version}.tar.sign"
> >  
> > +if [ $KUP -eq 1 ]; then
> > +	kup put \
> > +		xfsprogs-${version}.tar.gz \
> > +		xfsprogs-${version}.tar.sign \
> > +		pub/linux/utils/fs/xfs/xfsprogs/xfsprogs-${version}.tar.gz
> 
> Shouldn't this last argument be "pub/linux/utils/fs/xfs/xfsprogs/" ?

aha, it should (according to --help). But seems to works with
filename. I will change it to path

> 
> also you might want to put a sentence in the commit log for why you
> want this, e.g. "Add kup support so that the maintainer can push the
> newly formed release taballs to kernel.org."

sure

-- 
- Andrey





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux