Re: [PATCH] xfs: remove an out of data comment in _xfs_buf_alloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2025 at 07:03:35AM +0100, Christoph Hellwig wrote:
> There hasn't been anything like an io_length for a long time.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Yep, that old comment doesn't make much sense anymore
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/xfs_buf.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index dc219678003c..af3945bf7d94 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -241,11 +241,6 @@ _xfs_buf_alloc(
>  	bp->b_mount = target->bt_mount;
>  	bp->b_flags = flags;
>  
> -	/*
> -	 * Set length and io_length to the same value initially.
> -	 * I/O routines should use io_length, which will be the same in
> -	 * most cases but may be reset (e.g. XFS recovery).
> -	 */
>  	error = xfs_buf_get_maps(bp, nmaps);
>  	if (error)  {
>  		kmem_cache_free(xfs_buf_cache, bp);
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux