On Wed, Jan 15, 2025 at 06:21:55AM +0100, Christoph Hellwig wrote: > On Tue, Jan 14, 2025 at 01:41:25PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Newer versions of gcc and clang can include the ability to zero stack > > variables by default. Let's enable it so that we (a) reduce the risk of > > writing stack contents to disk somewhere and (b) try to reduce > > unpredictable program behavior based on random stack contents. The > > kernel added this 6 years ago, so I think it's mature enough for > > xfsprogs. > > Hmm, this tends to paper of bugs quite badly. But I guess we'd better > paper over bugs in the same way as the kernel code. Yeah, I've been thinking about this one for a couple of weeks -- yeah, it does paper over uninit variable bugs, but since the kernel does it we had better do that too if we want to keep porting random kernel code to support libxfs. :/ > Reluctantly-Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks for reviewing! --D
