Re: [PATCH 4/6] iomap: advance the iter directly on buffered writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2024 at 09:36:08AM -0500, Brian Foster wrote:
> +		loff_t pos = iter->pos;
> +		loff_t length = iomap_length(iter);

AFAICS we could just do away with these local variables as they should
never get out of sync with the values in the iter.  If so I'd love to see
that one.  If they can get out of sync and we actually need them, that
would warrant a comment.

Otherwise this looks good to me, and the same applies to the next two
patches.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux