On Mon, Jan 06, 2025 at 10:31:48PM -0800, Darrick J. Wong wrote: > On Mon, Jan 06, 2025 at 10:54:43AM +0100, Christoph Hellwig wrote: > > xfs_buf_delwri_submit_buffers has two callers for synchronous and > > asynchronous writes that share very little logic. Split out a helper for > > the shared per-buffer loop and otherwise open code the submission in the > > two callers. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > fs/xfs/xfs_buf.c | 121 +++++++++++++++++++++-------------------------- > > 1 file changed, 55 insertions(+), 66 deletions(-) > > Sheesh, splitting a function into two reduces line count by 11?? Well, most of that is the comment in the low-level function say it does either the thing the one callers wants which is already documented in that caller, or the thing the other caller wants already documented in that caller..
