On Mon, Jan 06, 2025 at 06:08:10PM -0800, Darrick J. Wong wrote: > > - * after I/O completion, reuse the original list as the wait list. > > - */ > > - xfs_buf_delwri_submit_buffers(&submit_list, buffer_list); > > + bp->b_flags &= ~(_XBF_DELWRI_Q | XBF_ASYNC); > > + bp->b_flags |= XBF_WRITE; > > + xfs_buf_submit(bp); > > Why is it ok to ignore the return value here? Is it because the only > error path in xfs_buf_submit is the xlog_is_shutdown case, in which case > the buffer ioend will have been called already and the EIO will be > returned by xfs_buf_iowait? A very good question to be asked to the author of the original xfs_buf_delwri_submit_buffers code that this go extracted from :) I think you're provided answer is correct and also implies that we should either get rid of the xfs_buf_submit return value or check it more consistently.
