Re: [PATCH v4 10/25] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






But that's a bit weird: we call __init_single_page()->init_page_count() to
initialize it to 1, to then set it back to 0.


Maybe we can just pass to __init_single_page() the refcount we want to have
directly? Can be a patch on top of course.

Once the dust settles on this series we won't need the pgmap->type check at
all because all ZONE_DEVICE pages will get an initial count of 0. I have some
follow up clean-ups for after this series is applied (particularly with regards
to pgmap refcounts), so if it's ok I'd rather do this as a follow-up.

Sure. For ordinary memory hotplug I'll also convert it to start with refcount=0 soonish, so there we're also simply pass 0 to __init_single_page.

--
Cheers,

David / dhildenb





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux