On Thu, Dec 12, 2024 at 10:23:33PM -0800, Christoph Hellwig wrote: > On Thu, Dec 12, 2024 at 05:01:37PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Add the ondisk structure definitions for realtime rmap btrees. The > > realtime rmap btree will be rooted from a hidden inode so it needs to > > have a separate btree block magic and pointer format. > > > > Next, add everything needed to read, write and manipulate rmap btree > > blocks. This prepares the way for connecting the btree operations > > implementation. > > This isn't really the entire on-disk format, because the metadata > btrees in data forks comes later in the series. Not sure how to > best word this, though. "This prepares the way for connecting the btree operations implementation, though embedding the rtrmap btree root in the inode comes later in the series." ? > > +#ifndef __XFS_RTRMAP_BTREE_H__ > > +#define __XFS_RTRMAP_BTREE_H__ > > The mix of a space for ifndef and a tab for define is a bit weird. > І'd suggest to pick one and stick to it. Will fix. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
