On Tue, Dec 17, 2024 at 05:27:35AM +0100, Christoph Hellwig wrote:
> Non-rtg file systems have a fake RT group even if they do not have a RT
> device, and thus an rgcount of 1. Ensure xfs_update_last_rtgroup_size
> doesn't fail when called for !XFS_RT to handle this case.
>
> Fixes: 87fe4c34a383 ("xfs: create incore realtime group structures")
> Reported-by: Brian Foster <bfoster@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/libxfs/xfs_rtgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_rtgroup.h b/fs/xfs/libxfs/xfs_rtgroup.h
> index 7e7e491ff06f..2d7822644eff 100644
> --- a/fs/xfs/libxfs/xfs_rtgroup.h
> +++ b/fs/xfs/libxfs/xfs_rtgroup.h
> @@ -272,7 +272,7 @@ static inline int xfs_initialize_rtgroups(struct xfs_mount *mp,
> }
>
> # define xfs_rtgroup_extents(mp, rgno) (0)
> -# define xfs_update_last_rtgroup_size(mp, rgno) (-EOPNOTSUPP)
> +# define xfs_update_last_rtgroup_size(mp, rgno) (0)
> # define xfs_rtgroup_lock(rtg, gf) ((void)0)
> # define xfs_rtgroup_unlock(rtg, gf) ((void)0)
> # define xfs_rtgroup_trans_join(tp, rtg, gf) ((void)0)
> --
> 2.45.2
>
