On Fri, Dec 13, 2024 at 06:04:39AM +0100, Christoph Hellwig wrote: > On Thu, Dec 12, 2024 at 01:18:43PM -0800, Darrick J. Wong wrote: > > On Wed, Dec 11, 2024 at 09:54:29AM +0100, Christoph Hellwig wrote: > > > Delalloc reservations are not supported in userspace, and thus it doesn't > > > make sense to share this helper with xfsprogs.c. Move it to xfs_iomap.c > > > toward the two callers. > > > > > > Note that there rest of the delalloc handling should probably eventually > > > also move out of xfs_bmap.c, but that will require a bit more surgery. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Not opposed since we /could/ move this back if userspace ever (a) grows > > a fuse server and (b) decides to use delalloc with it, but is this move > > totally necessary? > > It's not totally necessary, we could also mark xfs_bmap_worst_indlen and > xfs_bmap_add_extent_hole_delay non-static and be done with it. But then > again I'd rather reduce the unused libxfs sync surface if I can. <nod> Does anyone else have an opinion? Particularly any of the past xfsprogs maintainers? --D
