> xfs_rtbtree_compute_maxlevels( > struct xfs_mount *mp) > { > - mp->m_rtbtree_maxlevels = mp->m_rtrmap_maxlevels; > + unsigned int levels; > + > + levels = max(mp->m_rtrmap_maxlevels, mp->m_rtrefc_maxlevels); > + mp->m_rtbtree_maxlevels = levels; > } I'd drop the extra local variable here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>