Re: [PATCH 29/50] xfs_db: support changing the label and uuid of rt superblocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 09, 2024 at 09:42:08PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 06, 2024 at 04:12:31PM -0800, Darrick J. Wong wrote:
> >u +	struct xfs_mount	*mp)
> > +{
> > +	int			error;
> > +
> > +	if (!xfs_has_rtsb(mp) || !xfs_has_realtime(mp))
> 
> Nit: I would have expected the checks to be reversed just from a reading
> flow perspective:
> 
> 	if (!xfs_has_realtime(mp) || !xfs_has_rtsb(mp))
> 
> But in the end it does not matter.

I changed the order, since everywhere else does it this way too.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks!

--D




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux