On Mon, Dec 09, 2024 at 09:00:38PM -0800, Christoph Hellwig wrote: > On Fri, Dec 06, 2024 at 03:43:17PM -0800, Darrick J. Wong wrote: > > +extern int fp_metatype(void *obj, int bit, int count, char *fmtstr, > > + int size, int arg, int base, int array); > > No need for the extern here. Will remove. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you! --D