On Fri, Dec 06, 2024 at 03:47:43PM -0800, Darrick J. Wong wrote: > +{ > + struct ino_tree_node *irec; > + int ino_offset; > + > + irec = find_inode_rec(mp, XFS_INO_TO_AGNO(mp, ino), > + XFS_INO_TO_AGINO(mp, ino)); > + ino_offset = get_inode_offset(mp, ino, irec); > + set_inode_is_meta(irec, ino_offset); Nit: I'd do away with the ino_offset variable here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>