On Wed, Dec 04, 2024 at 07:50:28AM -0600, Eric Sandeen wrote: > When large extent counter / NREXT64 support was added to grub, it missed > a couple of direct reads of nextents which need to be changed to the new > NREXT64-aware helper as well. Without this, we'll have mis-reads of some > directories with this feature enabled. > > (The large extent counter fix likely raced on merge with > 07318ee7e ("fs/xfs: Fix XFS directory extent parsing") which added the new > direct nextents reads just prior, causing this issue.) Indeed 07318ee7e11a has a commit-date after the author-date of aa7c1322671e, so it wasn't applied to the tree yet when I submitted the patch: $ git show -s --pretty="%h %aI %cI" 07318ee7e aa7c1322671e 07318ee7e11a 2023-10-17T23:03:47-04:00 2023-10-30T18:01:22+01:00 aa7c1322671e 2023-10-26T11:53:39+02:00 2023-11-22T19:13:46+01:00 > Fixes: aa7c1322671e ("fs/xfs: Add large extent counters incompat feature support") > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Thanks for catching this, Reviewed-by: Anthony Iliopoulos <ailiop@xxxxxxxx> Regards, Anthony