Re: [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 25 Nov 2024 21:28:37 -0800
Cc: linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <173258398125.4032920.10688788085648644743.stgit@frogsfrogsfrogs>
References: <173258397748.4032920.4159079744952779287.stgit@frogsfrogsfrogs> <173258398125.4032920.10688788085648644743.stgit@frogsfrogsfrogs>

>  	if (test_bit(XFS_LI_IN_AIL, &lip->li_flags) &&
> -	    ((lip->li_lsn == qip->qli_flush_lsn) ||
> +	    ((lip->li_lsn == qlip->qli_flush_lsn) ||

Let's drop the superfluous inner braces here while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Follow-Ups:
- Re: [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}
  - From: Darrick J. Wong

References:
- [PATCHSET] xfs: bug fixes for 6.13
  - From: Darrick J. Wong
- [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 18/21] xfs: separate dquot buffer reads from xfs_dqflush
Next by Date: Re: [PATCH 20/21] xfs: attach dquot buffer to dquot log item buffer
Previous by thread: [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}
Next by thread: Re: [PATCH 19/21] xfs: clean up log item accesses in xfs_qm_dqflush{,_done}
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux