On Sun, Nov 24, 2024 at 10:40:20PM -0800, Christoph Hellwig wrote: > On Mon, Nov 25, 2024 at 10:33:40AM +0800, Long Li wrote: > > 1. collect reviewed tag > > 2. Modify the comment of io_size and iomap_ioend_size_aligned(). > > 3. Add explain of iomap_ioend_size_aligned() to commit message. > > Just curious, did you look into Brian's suggestions to do away > with the rounding up entirely as there is not much practical benefit > in merging behind EOF? > > I agree with Brian's point. The scenarios where rounding up io_size enables ioend merging are quite rare, so the practical benefits are limited, though such cases can still exist. Therefore, I think both approaches are acceptable as there doesn't seem to be a significant difference between them. Thanks, Long Li
