On Tue, Nov 19, 2024 at 08:15:43AM -0800, Darrick J. Wong wrote: > > + error = xfs_buf_read_uncached(mp->m_rtdev_targp, daddr, > > + XFS_FSB_TO_BB(mp, 1), 0, &bp, NULL); > > + if (error) > > + xfs_warn(mp, "cannot read last RT device block (%lld)", > > + last_block); > > "cannot read last RT device sector"? Something to hint that the units > are 512b blocks, not fsblocks? This is certainly better than the old > message. :) Sure. > Also, should there be a similar function to handle the last datadev > read that mount and growfs perform? I'll take a look.