On Wed, Nov 13, 2024 at 10:24:47PM -0800, Darrick J. Wong wrote: > Hi Carlos, > > Please pull these fully reviewed patchsets for kernel 6.13. This > patchbomb corrects numerous paperwork errors in the v5.5 submission so > that we can pass linux-next linter. > > I have corrected my stgit wrapper program to invoke git checkpatch > before issuing pull requests. Despite its name, this means I now have > automated checks for tagging errors in git commits. Freeform text > fields that require a lot of parsing cleverness to check and that can be > corrupted easily buc*********. > > This is now being resent as a v5.7 because hch pointed out that I got My 2cents here: don't change what's in linux-next for these kinds of nit picky warnings. Linus hates last minutes rebaseѕ, and having two patches attribute to your instead of me and a missing hex digit in a Fixes tag isn't worth the hazzle. But I've added him just in case I'm wrong. > > The following excerpted range diff shows the differences between last > week's PRs and this week's: > > 1: 62027820eb4486 ! 1: 0fed1fb2b6d4ef xfs: fix simplify extent lookup in xfs_can_free_eofblocks > @@ Commit message > this patch, we'd invoke xfs_free_eofblocks on first close if anything > was in the CoW fork. Now we don't do that. > > Fix the problem by reverting the removal of the i_delayed_blks check. > > Cc: <stable@xxxxxxxxxxxxxxx> # v6.12-rc1 > - Fixes: 11f4c3a53adde ("xfs: simplify extent lookup in xfs_can_free_eofblocks") > + Fixes: 11f4c3a53adde1 ("xfs: simplify extent lookup in xfs_can_free_eofblocks") > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > ## fs/xfs/xfs_bmap_util.c ## > @@ fs/xfs/xfs_bmap_util.c: xfs_can_free_eofblocks( > end_fsb = xfs_rtb_roundup_rtx(mp, end_fsb); > 2: cd8ae42a82d2d7 = 2: 3aeee6851476d4 xfs: fix superfluous clearing of info->low in __xfs_getfsmap_datadev > ... > 68: dcfc65befb76df ! 68: eae72acae5a564 xfs: clean up xfs_getfsmap_helper arguments > @@ Commit message > fsmap irec structure that contains exactly the data we need, once. > > Note that we actually do need rm_startblock for rmap key comparisons > when we're actually querying an rmap btree, so leave that field but > document why it's there. > > - Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > + Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > + [djwong: fix the SoB tag from hch, somehow my scripts replaced it...] > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > ## fs/xfs/xfs_fsmap.c ## > @@ fs/xfs/xfs_fsmap.c: xfs_fsmap_owner_to_rmap( > } > return 0; > 69: 87fe4c34a383d5 = 69: f106058ca77fa9 xfs: create incore realtime group structures > ... > 83: 1029f08dc53920 ! 83: 12693186fbb282 xfs: factor out a xfs_growfs_rt_alloc_fake_mount helper > @@ > ## Metadata ## > -Author: Darrick J. Wong <djwong@xxxxxxxxxx> > +Author: Christoph Hellwig <hch@xxxxxx> > > ## Commit message ## > xfs: factor out a xfs_growfs_rt_alloc_fake_mount helper > > Split the code to set up a fake mount point to calculate new RT > geometry out of xfs_growfs_rt_bmblock so that it can be reused. > 84: fc233f1fb0588a = 84: 52690d80b09ca5 xfs: use xfs_growfs_rt_alloc_fake_mount in xfs_growfs_rt_alloc_blocks > ... > 110: b91afef724710e ! 110: d4918d151be0bd xfs: don't merge ioends across RTGs > @@ > ## Metadata ## > -Author: Darrick J. Wong <djwong@xxxxxxxxxx> > +Author: Christoph Hellwig <hch@xxxxxx> > > ## Commit message ## > xfs: don't merge ioends across RTGs > > Unlike AGs, RTGs don't always have metadata in their first blocks, and > thus we don't get automatic protection from merging I/O completions > 111: d162491c5459f4 = 111: 54a89f75c4d972 xfs: make the RT allocator rtgroup aware > ... > 139: 13877bc79d8135 = 139: c70402363d6d27 xfs: port ondisk structure checks from xfs/122 to the kernel > > Apologies for the last minute churn and paperwork stress. > > --D ---end quoted text---