On Thu, Nov 07, 2024 at 08:29:53AM +0100, Christoph Hellwig wrote: > On Wed, Nov 06, 2024 at 11:18:38AM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Document the ondisk format changes for metadata directories. > > > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > --- > > .../allocation_groups.asciidoc | 14 +- > > .../internal_inodes.asciidoc | 113 ++++++++++++++++++++ > > .../XFS_Filesystem_Structure/ondisk_inode.asciidoc | 22 ++++ > > 3 files changed, 142 insertions(+), 7 deletions(-) > > > > > > diff --git a/design/XFS_Filesystem_Structure/allocation_groups.asciidoc b/design/XFS_Filesystem_Structure/allocation_groups.asciidoc > > index d7fd63ea20a646..ec59519dc2ffc1 100644 > > --- a/design/XFS_Filesystem_Structure/allocation_groups.asciidoc > > +++ b/design/XFS_Filesystem_Structure/allocation_groups.asciidoc > > @@ -105,7 +105,7 @@ struct xfs_sb > > xfs_ino_t sb_pquotino; > > xfs_lsn_t sb_lsn; > > uuid_t sb_meta_uuid; > > - xfs_ino_t sb_rrmapino; > > + xfs_ino_t sb_metadirino; > > }; > > Not new here, but I find it a bit odd that the super block is documented > in allocation_groups.asciidoc. Me too. superblock.asciidoc? > The change itself looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
