On Fri, Nov 01, 2024 at 03:19:05PM -0700, Darrick J. Wong wrote: > +#define XFS_CHECK_SB_OFFSET(field, offset) \ > + XFS_CHECK_OFFSET(struct xfs_dsb, field, offset); \ > + XFS_CHECK_OFFSET(struct xfs_sb, field, offset); Despite comments to the contrary, xfs_sb is purely an in-memory structure and nothing cares about it having the same layout as xfs_dsb. As we've kept them in sync so far I'm fine with adding this check under the expectation that I can remove it again when I finally start removing struct xfs_sb, which is long overdue. Otherwise: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
