On 10/31/24 06:08, Christoph Hellwig wrote: > xfs_zero_extent does some really odd gymnstics to calculate the block > layer sectors numbers passed to blkdev_issue_zeroout. This is because it > used to call sb_issue_zeroout and the calculations in that helper got > open coded here in the rather misleadingly named commit 3dc29161070a > ("dax: use sb_issue_zerout instead of calling dax_clear_sectors"). > > Signed-off-by: Christoph Hellwig<hch@xxxxxx> much cleaner like what xfs_discard_rtdev_extents() and xfs_discard_extents() is doing. Looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck