On Thu, Oct 24, 2024 at 09:55:44AM -0700, Darrick J. Wong wrote: > On Thu, Oct 24, 2024 at 01:51:05PM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > It's just read in from the superblock and used without doing any > > validity checks at all on the value. > > > > Fixes: fb4f2b4e5a82 ("xfs: add sparse inode chunk alignment superblock field") > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.2 Yeah. And probably what ever fix we decide on, too. > Oof yeah that's quite a gap! *nod* What surprises me is that syzbot hasn't found this - it's exactly the sort of thing that randomised structure fuzzing is supposed to find..... > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Thanks! -Dave. -- Dave Chinner david@xxxxxxxxxxxxx