On 22:47 21/10, Christoph Hellwig wrote: > On Fri, Oct 18, 2024 at 11:55:50AM -0400, Goldwyn Rodrigues wrote: > > Reduces the number of arguments to functions iomap_writepages() and > > all functions in the writeback path which require both wpc and wbc. > > The filesystems need to initialize wpc with wbc before calling > > iomap_writepages(). > > While this looks obviously correct, I'm not sure what the point of > it is as it adds slightly more lines of code. Does it generate > better binary code? Do you have future changes that depend on it? > No future updates depending on it. It just makes the code more readable. No point bouncing two pointers to different functions in the write- back path, when one can be encompassed into another. -- Goldwyn
