On Mon, Oct 21, 2024 at 02:59:27PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Apparently C++ compilers don't like the implicit void* casts that go on > in the system headers. Compile a dummy program with the C++ compiler to > make sure this works. The subject line looks weird. This is test compiling the public headers with a C++ compiler, not libxfs itself. Maybe make this a bit more clear? The change itself looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>