On Thu, Oct 17, 2024 at 11:55:09AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > The predicate xfs_internal_inum tells us if an inumber refers to one of > the inodes rooted in the superblock. Soon we're going to have internal > inodes in a metadata directory tree, so this helper should be renamed > to capture its limited scope. > > Ondisk inodes will soon have a flag to indicate that they're metadata > inodes. Head off some confusion by renaming the xfs_is_metadata_inode > predicate to xfs_is_internal_inode. I don't really care either way, but the patch looks correct: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
