On Tue, Oct 15, 2024 at 09:11:41AM -0400, Brian Foster wrote: > > index 25cec9dc10c941..5ca8d01068273d 100644 > > --- a/fs/xfs/libxfs/xfs_ag.c > > +++ b/fs/xfs/libxfs/xfs_ag.c > > @@ -273,6 +273,23 @@ xfs_agino_range( > > return __xfs_agino_range(mp, xfs_ag_block_count(mp, agno), first, last); > > } > > > > Comment please. I.e., > > /* > * Update the perag of the previous tail AG if it has been changed > * during recovery (i.e. recovery of a growfs). > */ Sure. > > + /* > > + * Growfs can also grow the last existing AG. In this case we also need > > It can shrink the last AG as well, FWIW. Indeed, I keep forgetting about the weird special case partial shrink that we support. > > - error = xfs_initialize_perag(mp, orig_agcount, > > - mp->m_sb.sb_agcount, mp->m_sb.sb_dblocks, > > - &mp->m_maxagi); > > + error = xfs_initialize_perag(mp, orig_agcount, mp->m_sb.sb_agcount, > > + mp->m_sb.sb_dblocks, &mp->m_maxagi); > > Seems like this should be folded into an earlier patch? Yes.
