On Tue, Oct 01, 2024 at 10:49:18AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 30, 2024 at 09:50:19AM -0700, Darrick J. Wong wrote:
> > > +int
> > > +xlog_recover_update_agcount(
> > > + struct xfs_mount *mp,
> > > + struct xfs_dsb *dsb)
> > > +{
> > > + xfs_agnumber_t old_agcount = mp->m_sb.sb_agcount;
> > > + int error;
> > > +
> > > + xfs_sb_from_disk(&mp->m_sb, dsb);
> >
> > If I'm understanding this correctly, the incore superblock gets updated
> > every time recovery finds a logged primary superblock buffer now,
> > instead of once at the end of log recovery, right?
>
> Yes.
>
> > Shouldn't this conversion be done in the caller? Some day we're going
> > to want to do the same with xfs_initialize_rtgroups(), right?
>
> Yeah. But the right "fix" for that is probably to just rename
> this function :) Probably even for the next repost instead of
> waiting for more features.
Forgot to reply to this, but yes, how about
xlog_recover_update_group_count?
--D
