s/deallayed/delayed/ > > +static inline bool xfs_inode_has_data(struct xfs_inode *ip) > +{ > + return (ip->i_df.if_nextents > 0 || ip->i_delayed_blks > 0); Nit: no need for the braces. > + if (S_ISREG(VFS_I(ip)->i_mode) && > + xfs_inode_has_data(ip) && This can now be condensed to: if (S_ISREG(VFS_I(ip)->i_mode) && xfs_inode_has_data(ip) && Otherwise this still looks good to me.