On Tue, Oct 01, 2024 at 10:54:39PM -0700, Christoph Hellwig wrote: > > if (xfs_sb_version_hasmetauuid(sb)) > > - size = offsetof(xfs_sb_t, sb_meta_uuid) > > + size = offsetof(struct xfs_dsb, sb_meta_uuid) > > + sizeof(sb->sb_meta_uuid); > > It would be nice to fix the formatting here, or maybe even add a a > field_end() or simіlar helper here.. I think that's part of the metadir patchset, in "xfs_repair: refactor offsetof+sizeof to offsetofend". > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thank you! --D
