Re: fix a DEBUG-only assert failure in xfs/538 v5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 18 Sep 2024 07:30:02 +0200, Christoph Hellwig wrote:
> when testing with very small rtgroups I've seen relatively frequent
> failures in xfs/538 where an assert about the da block type triggers
> that should be entirely impossible to trigger by the expected code
> flow.
> 
> It turns out for this two things had to come together:  a bug in the
> attr code to uses ENOSPC to signal a condition that is not related
> to run out free blocks, but which can also be triggered when we
> actually run out of free blocks, and a debug in the DEBUG only
> xfs_bmap_exact_minlen_extent_alloc allocator trigger only by the
> specific error injection used in this and a few other tests.
> 
> [...]

Applied to xfs-6.12-rc2, thanks!

[1/8] xfs: merge xfs_attr_leaf_try_add into xfs_attr_leaf_addname
      commit: 5e0213630ca21fa28d72731a0d2982382a7e5ddd
[2/8] xfs: return bool from xfs_attr3_leaf_add
      commit: be2a6813d74bcf509d1c2e114444899d068fd4cc
[3/8] xfs: distinguish extra split from real ENOSPC from xfs_attr3_leaf_split
      commit: 835d458fa866c7a0f62385f099a64e185e7eac0c
[4/8] xfs: distinguish extra split from real ENOSPC from xfs_attr_node_try_addname
      commit: 1ed79d6d6d939ff7e930d8ab2ca3c7a56a5b9df8
[5/8] xfs: fold xfs_bmap_alloc_userdata into xfs_bmapi_allocate
      commit: f5aa89bbab30305d09bc47cdf78c40dd3f8fec86
[6/8] xfs: don't ifdef around the exact minlen allocations
      commit: 1ac3384880176af2c6fbfc72a3dece8c65940e85
[7/8] xfs: call xfs_bmap_exact_minlen_extent_alloc from xfs_bmap_btalloc
      commit: 13de5fbeb24f9a038a3ed2e166e940c5c2189fa8
[8/8] xfs: support lowmode allocations in xfs_bmap_exact_minlen_extent_alloc
      commit: b6d38bcff02598735e382c3a7d774548fc652fce

Best regards,
-- 
Carlos Maiolino <cem@xxxxxxxxxx>





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux