Re: Re: [PATCH 1/2] xfsprogs: fix permissions on files installed by libtoolize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-09-27 08:17:09, Darrick J. Wong wrote:
> On Fri, Sep 27, 2024 at 03:41:42PM +0200, Andrey Albershteyn wrote:
> > Libtoolize installs some set of AUX files from its system package.
> > Not all distributions have the same permissions set on these files.
> > For example, read-only libtoolize system package will copy those
> > files without write permissions. This causes build to fail as next
> > line copies ./include/install-sh over ./install-sh which is not
> > writable.
> 
> Does cp -f include/install-sh . work for this?

yes, the cp -f would also work, to fix the build issue

> 
> Aside from the install script, the build system doesn't modify any of
> the files that come in from libtol, does it?

yup, it doesn't (at least I didn't found anything else), but the
file mode would be different

Andrey

> 
> --D
> 
> > Fix this by setting permission explicitly on files copied by
> > libtoolize.
> > 
> > Signed-off-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx>
> > ---
> >  Makefile | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index 4e768526c6fe..11cace1112e6 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -109,6 +109,8 @@ endif
> >  
> >  configure: configure.ac
> >  	libtoolize -c -i -f
> > +	chmod 755 config.guess config.sub install-sh
> > +	chmod 644 ltmain.sh m4/{libtool,ltoptions,ltsugar,ltversion,lt~obsolete}.m4
> >  	cp include/install-sh .
> >  	aclocal -I m4
> >  	autoconf
> > -- 
> > 2.44.1
> > 
> > 
> 

-- 
- Andrey





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux