On Tue, Sep 10, 2024 at 07:28:47AM +0300, Christoph Hellwig wrote:
> __GFP_RETRY_MAYFAIL increases the likelyhood of allocations to fail,
> which isn't really helpful during log recovery. Remove the flag and
> stick to the default GFP_KERNEL policies.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Sounds fine to me
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/libxfs/xfs_ag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c
> index 3f695100d7ab58..f6c666a87dd393 100644
> --- a/fs/xfs/libxfs/xfs_ag.c
> +++ b/fs/xfs/libxfs/xfs_ag.c
> @@ -289,7 +289,7 @@ xfs_initialize_perag(
> return 0;
>
> for (index = old_agcount; index < agcount; index++) {
> - pag = kzalloc(sizeof(*pag), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
> + pag = kzalloc(sizeof(*pag), GFP_KERNEL);
> if (!pag) {
> error = -ENOMEM;
> goto out_unwind_new_pags;
> --
> 2.45.2
>
>
