On Tue, 27 Aug 2024 16:15:05 -0700, Nathan Chancellor wrote:
> When building for a 32-bit architecture, where 'size_t' is 'unsigned
> int', there is a warning due to use of '%ld', the specifier for a 'long
> int':
>
> In file included from fs/xfs/xfs_linux.h:82,
> from fs/xfs/xfs.h:26,
> from fs/xfs/xfs_super.c:7:
> fs/xfs/xfs_super.c: In function 'xfs_fs_fill_super':
> fs/xfs/xfs_super.c:1654:1: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1655 | mp->m_sb.sb_blocksize, max_folio_size);
> | ~~~~~~~~~~~~~~
> | |
> | size_t {aka unsigned int}
> ...
> fs/xfs/xfs_super.c:1654:58: note: format string is defined here
> 1654 | "block size (%u bytes) not supported; Only block size (%ld) or less is supported",
> | ~~^
> | |
> | long int
> | %d
>
> [...]
The fix has been folded into the commit it fixes and a Link tag has been added
noting that this patch has been folded. Thanks!
---
Applied to the vfs.blocksize branch of the vfs/vfs.git tree.
Patches in the vfs.blocksize branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.blocksize
[1/1] xfs: Fix format specifier for max_folio_size in xfs_fs_fill_super()
(no commit info)
